grpc-js-xds: Add interop server implementation #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
murgatroid99
force-pushed
the
grpc-js-xds_interop_server
branch
from
d5ea254 to
8fea44d
Compare
murgatroid99
added a commit
to grpc/psm-interop
that referenced
this pull request
Feb 5, 2025
This modifies the driver to use the Node interop server implemented in grpc/grpc-node#2897 whenever possible. Test runs: - [x] [grpc/node/master/xds_k8s_lb](https://source.cloud.google.com/results/invocations/5eda22ed-1bf6-4a9e-b7ee-7da93c2dfa09) - [ ] ~[grpc/node/master/psm-dualstack](https://source.cloud.google.com/results/invocations/407b7ba1-ce14-4e3d-a025-b9219fffb3e1)~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the interop server implementation code itself, the corresponding Dockerfile, and the test script changes. In addition, I made a couple of small changes to the library code:
sendMetadatamethod in server interceptors to not be called if the handler function did not explicitly send metadata.This change is tested with the corresponding interop driver change at grpc/node/master/xds_k8s_lb and grpc/node/master/psm-dualstack.