grpc-js: Connect with https scheme when using TLS #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug caught by interop tests that caused Google Front End servers to reject requests made by this library over TLS. Our best guess at a proximate cause for this error is that the request has an unexpected
:schemeheader value ofhttpinstead ofhttpsbecause that is the scheme used in the URL passed tohttp2.connect.In order to consistently use the correct scheme,
SecureConnector#connectnow annotates the result with an additional field indicating whether the connection is secure, and this value determines the scheme.