grpc-js: Fix client hang when receiving extra messages for a unary response #2772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnossen
approved these changes
Jun 7, 2024
murgatroid99
merged commit 52fe8e9
into
grpc:@grpc/[email protected]
4 of 5 checks passed
|
We should not use UNIMPLEMENTED. It is very bad if it ever gets triggered. Please swap back to INTERNAL. We will change the spec. |
|
Is it really that bad? I would say that if a server responds with multiple messages to a method that the client believes is unary or client streaming, the server doesn't implement the method the client is intends to access. In any case, as long as this is what the spec says, I consider it to be correct behavior. If and when the spec changes, I'll make the change here too. But as far as I know Python and C++ also have this behavior, so it is consistent with (some) other languages. |
This was referenced Jul 18, 2024
This was referenced Jul 25, 2024
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new
call.startRead()call is the fix for the main bug. Previously the I also changed the client to use theUNIMPLEMENTEDstatus code for cardinality violations to make it consistent with the server, and because that is what the spec actually says.This fixes #2768.