Native: Copy slice data into Buffer when receiving binary metadata #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasnoble
approved these changes
Oct 29, 2020
|
@murgatroid99 thank you Michael |
|
@murgatroid99 no way? :( |
|
Sorry, I'm working on the release in #1615. There have been some build issues. |
|
I have published version 1.24.4, which includes this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #1407, or at least the reproduction demonstrated in #1407 (comment). This change is needed because of change in Node 14 that prohibits multiple
Bufferobjects from pointing to the same underlying memory. That makes the previous zero-copy function error-prone in some situations.