Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export health-check messages #1351

Merged
merged 1 commit into from
Apr 16, 2020

Conversation

doochik
Copy link
Contributor

@doochik doochik commented Apr 12, 2020

To use in serviceMap.

Before

const grpcHealthCheck = require('grpc-health-check');
const grpcHealthCheckMessages = require('grpc-health-check/v1/health_pb');
const statusMap = {
    '': grpcHealthCheckMessages.HealthCheckResponse.ServingStatus.SERVING,
};
const healthImpl = new grpcHealthCheck.Implementation(statusMap);
server.addService(grpcHealthCheck.service, healthImpl);

After

const grpcHealthCheck = require('grpc-health-check');
const statusMap = {
    '': grpcHealthCheck.messages.HealthCheckResponse.ServingStatus.SERVING,
};
const healthImpl = new grpcHealthCheck.Implementation(statusMap);
server.addService(grpcHealthCheck.service, healthImpl);

To use in serviceMap

const grpcHealthCheck = require('grpc-health-check');
const statusMap = {
    '': grpcHealthCheck.messages.HealthCheckResponse.ServingStatus.SERVING,
};
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 12, 2020

CLA Check
The committers are authorized under a signed CLA.

Copy link
Member

@murgatroid99 murgatroid99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.

@murgatroid99 murgatroid99 merged commit 37d4acd into grpc:master Apr 16, 2020
@murgatroid99
Copy link
Member

I have published this in version 1.8.0

@doochik
Copy link
Contributor Author

doochik commented Apr 17, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants