Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle 'too_many_pings' error from server #1164

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

murgatroid99
Copy link
Member

This implements the following paragraph of the basic keepalive spec:

When a client receives a GOAWAY with error code ENHANCE_YOUR_CALM and debug data equal to ASCII "too_many_pings", it should log the occurrence at a log level that is enabled by default and double the configure KEEPALIVE_TIME used for new connections on that channel.

The 'goaway' event arguments are described here

The main goal here is to add the required logging, which may give us more information about what is causing #1158.

The previous behavior here is actually the same as in the core. See grpc/grpc#16210.

@murgatroid99 murgatroid99 merged commit 73a767d into grpc:master Nov 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants