-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prepare for 1.2.1 #315
prepare for 1.2.1 #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor suggestions that I am more than okay with you dismissing entirely. Looks great!
on: | ||
push: | ||
tags: | ||
- v** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the workflow syntax cheatsheet:
**: Matches zero or more of any character.
Works for me, but is there a specific reason not to make this simply "*"
?
- v** | |
- "*" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was thinking we only want to run this on tags that are prefixed with v
(releases).
- name: release | ||
env: | ||
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} | ||
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | ||
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }} | ||
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }} | ||
run: | | ||
# todo: verify version is same as tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe too much of a hack??
- name: release | |
env: | |
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} | |
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | |
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }} | |
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }} | |
run: | | |
# todo: verify version is same as tag | |
- id: getTag | |
name: Get Tag | |
run: echo ::set-output name=tag::${GITHUB_REF#refs/*/} | |
- name: release | |
env: | |
SONATYPE_USERNAME: ${{ secrets.SONATYPE_USERNAME }} | |
SONATYPE_PASSWORD: ${{ secrets.SONATYPE_PASSWORD }} | |
GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }} | |
GPG_PASSPHRASE: ${{ secrets.GPG_PASSPHRASE }} | |
TAG_NAME: ${{ steps.getTag.outputs.tag }} | |
run: | | |
if [[ -z $(grep CURRENT_GRPC_KOTLIN_VERSION build.gradle.kts | grep ${TAG_NAME:1}) ]]; | |
then | |
exit 1; | |
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about something like that. But a few things that we could do:
- There is now a better way to get the tag:
GITHUB_REF_NAME
- I think instead of parsing the build file it might be nice to have a task to get the value of
version
so we don't have to do mucky parsing
Let's keep that for a follow-on task and see if this thing even works first.
No description provided.