docs: Clarify BCR (non)publishing, and document git_override tip#12135
Closed
vorburger wants to merge 1 commit intogrpc:masterfrom
Closed
docs: Clarify BCR (non)publishing, and document git_override tip#12135vorburger wants to merge 1 commit intogrpc:masterfrom
git_override tip#12135vorburger wants to merge 1 commit intogrpc:masterfrom
Conversation
Contributor
Author
|
@kannanjgithub @ejona86 review? IMHO this might help reduce some confusion. |
ejona86
reviewed
Jun 9, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
The README doesn't talk about modules, and repository.bzl and those various Bazel pieces. I think the example is what's being relied on more for this. And the example has a comment saying to use a version from BCR.
Should we update the MODULE.bazel instead? We can do something similar to what we did in the WORKSPACE
vorburger
added a commit
to vorburger/enola
that referenced
this pull request
Sep 4, 2025
vorburger
added a commit
to vorburger/enola
that referenced
this pull request
Sep 4, 2025
vorburger
added a commit
to enola-dev/enola
that referenced
this pull request
Sep 4, 2025
Member
|
#12368 merged instead |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #12055.