optimize number of buffer allocations #11879
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejona86
reviewed
Feb 4, 2025
| @@ -27,9 +27,6 @@ | |||
| */ | |||
| class OkHttpWritableBufferAllocator implements WritableBufferAllocator { | |||
|
|
|||
| // Use 4k as our minimum buffer size. | |||
| private static final int MIN_BUFFER = 4096; | |||
There was a problem hiding this comment.
Okio Buffer works quite differently than Netty. Okio uses Segments that are all the same size and then combines adjacent buffers to avoid excessive internal fragmentation. We should leave this in-place and actually set it to 8192.
There was a problem hiding this comment.
(If we were more serious, we'd round up: (capacityHint + 8191) / 8192 * 8192.)
panchenko
changed the title
|
I think I see what you're trying to do, but I'm not sure this is how we want to do it. You've basically realized that we needed the minimum allocation size for unknown message sizes/compression. It seems we should quickly revert the Netty/Servlet changes, since those are known to cause regressions. And I need to stare at this more. CC @shivaspeaks |
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this improves 2 flows
Known length message which length is greater than 1Mb
previously the first buffer was 1Mb, and then many buffers of 4096 bytes (from CodedOutputStream), now subsequent buffers are also up to 1Mb
in case of compression, the first write is always 10 bytes buffer (gzip header), but worth allocating more space