Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version upgrades #11874

Merged
merged 23 commits into from
Feb 11, 2025
Merged
Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
77c7ccf
in-progress changes
kannanjgithub Jan 16, 2025
659baf5
Version upgrades. Upgrading org.eclipse.jetty:jetty-servlet:11.0.24 t…
kannanjgithub Jan 21, 2025
9278833
Undo jetty ee10 migration for now.
kannanjgithub Feb 1, 2025
4bd09bd
Fix jetty servlet version upgrades.
kannanjgithub Feb 1, 2025
dc2d2b1
Merge branch 'grpc:master' into versionupgrade
kannanjgithub Feb 3, 2025
1417894
Revert jakarta version upgrades, since it fails build about Java 11 c…
kannanjgithub Feb 3, 2025
528e731
Revert errorprone version upgrades, requires higher Java version.
kannanjgithub Feb 3, 2025
318a6a9
Revert guava upgrade since it seems to require higher erorrprone anno…
kannanjgithub Feb 3, 2025
89f15d0
Revert guava upgrade since it seems to require higher erorrprone anno…
kannanjgithub Feb 4, 2025
ab540c5
Re-introduce jetty servlet upgrades, the error was due to jakarta-ser…
kannanjgithub Feb 4, 2025
b9ef60e
Figured we can't upgrade google-auth libraries and the error_prone_an…
kannanjgithub Feb 4, 2025
4801e34
Only compile and run Jetty test if Java 17.
kannanjgithub Feb 5, 2025
85d7688
Use 'release' setting instead of 'compatibility' setting for compileJ…
kannanjgithub Feb 6, 2025
4c2e988
Deprecated.forRelease was added in Java 9, so the release compatibili…
kannanjgithub Feb 7, 2025
4070038
Update versions in the various version files
kannanjgithub Feb 7, 2025
d872af8
Re-add java compilation source compatibility as Java 8 for servlet ja…
kannanjgithub Feb 10, 2025
9b7893f
Try changing android min-sdk to 21 because :grpc-android-interop-test…
kannanjgithub Feb 11, 2025
a69f514
Try changing android min-sdk to 21 because :grpc-android-interop-test…
kannanjgithub Feb 11, 2025
ca509bc
Try minsdk 21 in build.gradle like before (instead of just in Android…
kannanjgithub Feb 11, 2025
51c3731
Fix syntax.
kannanjgithub Feb 11, 2025
cf00cca
Remove android-annotations upgrade since some new android failures ht…
kannanjgithub Feb 11, 2025
4be920a
androidx-core cannot be upgraded to 1.15.0: https://btx.cloud.google.…
kannanjgithub Feb 11, 2025
d2871e3
androidx-core cannot be upgraded to 1.15.0: https://btx.cloud.google.…
kannanjgithub Feb 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 26 additions & 20 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,19 @@ protobuf = "3.25.5"

[libraries]
android-annotations = "com.google.android:annotations:4.1.1.4"
androidx-annotation = "androidx.annotation:annotation:1.9.0"
androidx-core = "androidx.core:core:1.13.1"
androidx-lifecycle-common = "androidx.lifecycle:lifecycle-common:2.8.6"
androidx-lifecycle-service = "androidx.lifecycle:lifecycle-service:2.8.6"
androidx-annotation = "androidx.annotation:annotation:1.9.1"
androidx-core = "androidx.core:core:1.15.0"
androidx-lifecycle-common = "androidx.lifecycle:lifecycle-common:2.8.7"
androidx-lifecycle-service = "androidx.lifecycle:lifecycle-service:2.8.7"
androidx-test-core = "androidx.test:core:1.6.1"
androidx-test-ext-junit = "androidx.test.ext:junit:1.2.1"
androidx-test-rules = "androidx.test:rules:1.6.1"
animalsniffer = "org.codehaus.mojo:animal-sniffer:1.24"
animalsniffer-annotations = "org.codehaus.mojo:animal-sniffer-annotations:1.24"
assertj-core = "org.assertj:assertj-core:3.26.3"
assertj-core = "org.assertj:assertj-core:3.27.2"
auto-value = "com.google.auto.value:auto-value:1.11.0"
auto-value-annotations = "com.google.auto.value:auto-value-annotations:1.11.0"
checkstyle = "com.puppycrawl.tools:checkstyle:10.19.0"
checkstyle = "com.puppycrawl.tools:checkstyle:10.21.1"
commons-math3 = "org.apache.commons:commons-math3:3.6.1"
conscrypt = "org.conscrypt:conscrypt-openjdk-uber:2.5.2"
cronet-api = "org.chromium.net:cronet-api:119.6045.31"
Expand All @@ -34,32 +34,38 @@ cronet-embedded = "org.chromium.net:cronet-embedded:119.6045.31"
errorprone-annotations = "com.google.errorprone:error_prone_annotations:2.30.0"
# error-prone 2.32.0+ require Java 17+
errorprone-core = "com.google.errorprone:error_prone_core:2.31.0"
google-api-protos = "com.google.api.grpc:proto-google-common-protos:2.48.0"
google-api-protos = "com.google.api.grpc:proto-google-common-protos:2.50.1"
# google-auth-library 1.25.0+ requires error_prone_annotations 2.31.0+, which
# breaks the Android build
google-auth-credentials = "com.google.auth:google-auth-library-credentials:1.24.1"
google-auth-oauth2Http = "com.google.auth:google-auth-library-oauth2-http:1.24.1"
# Release notes: https://cloud.google.com/logging/docs/release-notes
google-cloud-logging = "com.google.cloud:google-cloud-logging:3.20.6"
google-cloud-logging = "com.google.cloud:google-cloud-logging:3.21.1"
gson = "com.google.code.gson:gson:2.11.0"
# 33.4.0 requires com.google.errorprone:error_prone_annotations:2.36.0 but we are stuck with 2.30.0 (see above)
guava = "com.google.guava:guava:33.3.1-android"
guava-betaChecker = "com.google.guava:guava-beta-checker:1.0"
guava-testlib = "com.google.guava:guava-testlib:33.3.1-android"
guava-testlib = "com.google.guava:guava-testlib:33.1.0-android"
# JRE version is needed for projects where its a transitive dependency, f.e. gcp-observability.
# May be different from the -android version.
guava-jre = "com.google.guava:guava:33.3.1-jre"
hdrhistogram = "org.hdrhistogram:HdrHistogram:2.2.2"
# 6.0.0+ use java.lang.Deprecated forRemoval and since from Java 9
jakarta-servlet-api = "jakarta.servlet:jakarta.servlet-api:5.0.0"
# Not using the relocated org.apache.tomcat:tomcat-annotations-api because it requires migrating
# java.annotation to jakarta.annotation. According to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9179 is a better reference. Basically, javax.annotation.Generated was fine because it was part of the JDK. And then it moved out of the JDK and then it was renamed. We have no desire to depend on J2EE for this.

There's also #11086 which lets you turn off the annotation.

# https://github.com/grpc/grpc-java/issues/6833#issuecomment-602242609
# there are so many different artifacts containing it, which causes classpath collisions.
javax-annotation = "org.apache.tomcat:annotations-api:6.0.53"
javax-servlet-api = "javax.servlet:javax.servlet-api:4.0.1"
# 12.0.0+ require Java 17+
jetty-client = "org.eclipse.jetty:jetty-client:11.0.24"
jetty-http2-server = "org.eclipse.jetty.http2:http2-server:11.0.24"
jetty-http2-server = "org.eclipse.jetty.http2:jetty-http2-server:12.0.16"
ejona86 marked this conversation as resolved.
Show resolved Hide resolved
jetty-http2-server10 = "org.eclipse.jetty.http2:http2-server:10.0.20"
jetty-servlet = "org.eclipse.jetty:jetty-servlet:11.0.24"
jetty-servlet = "org.eclipse.jetty.ee10:jetty-ee10-servlet:12.0.16"
jetty-servlet10 = "org.eclipse.jetty:jetty-servlet:10.0.20"
jsr305 = "com.google.code.findbugs:jsr305:3.0.2"
# 4.9.0+ requires Java 11.
jsr305 = "com.github.spotbugs:spotbugs-annotations:4.8.6"
ejona86 marked this conversation as resolved.
Show resolved Hide resolved
junit = "junit:junit:4.13.2"
# 2.17+ require Java 11+ (not mentioned in release notes)
lincheck = "org.jetbrains.kotlinx:lincheck-jvm:2.16"
Expand All @@ -85,18 +91,18 @@ opencensus-contrib-grpc-metrics = { module = "io.opencensus:opencensus-contrib-g
opencensus-exporter-stats-stackdriver = { module = "io.opencensus:opencensus-exporter-stats-stackdriver", version.ref = "opencensus" }
opencensus-exporter-trace-stackdriver = { module = "io.opencensus:opencensus-exporter-trace-stackdriver", version.ref = "opencensus" }
opencensus-impl = { module = "io.opencensus:opencensus-impl", version.ref = "opencensus" }
opentelemetry-api = "io.opentelemetry:opentelemetry-api:1.43.0"
opentelemetry-exporter-prometheus = "io.opentelemetry:opentelemetry-exporter-prometheus:1.43.0-alpha"
opentelemetry-gcp-resources = "io.opentelemetry.contrib:opentelemetry-gcp-resources:1.40.0-alpha"
opentelemetry-sdk-extension-autoconfigure = "io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:1.43.0"
opentelemetry-sdk-testing = "io.opentelemetry:opentelemetry-sdk-testing:1.43.0"
opentelemetry-api = "io.opentelemetry:opentelemetry-api:1.46.0"
opentelemetry-exporter-prometheus = "io.opentelemetry:opentelemetry-exporter-prometheus:1.46.0-alpha"
opentelemetry-gcp-resources = "io.opentelemetry.contrib:opentelemetry-gcp-resources:1.43.0-alpha"
opentelemetry-sdk-extension-autoconfigure = "io.opentelemetry:opentelemetry-sdk-extension-autoconfigure:1.46.0"
opentelemetry-sdk-testing = "io.opentelemetry:opentelemetry-sdk-testing:1.46.0"
perfmark-api = "io.perfmark:perfmark-api:0.27.0"
protobuf-java = { module = "com.google.protobuf:protobuf-java", version.ref = "protobuf" }
protobuf-java-util = { module = "com.google.protobuf:protobuf-java-util", version.ref = "protobuf" }
protobuf-javalite = { module = "com.google.protobuf:protobuf-javalite", version.ref = "protobuf" }
protobuf-protoc = { module = "com.google.protobuf:protoc", version.ref = "protobuf" }
re2j = "com.google.re2j:re2j:1.7"
robolectric = "org.robolectric:robolectric:4.13"
re2j = "com.google.re2j:re2j:1.8"
robolectric = "org.robolectric:robolectric:4.14.1"
signature-android = "net.sf.androidscents.signature:android-api-level-21:5.0.1_r2"
signature-java = "org.codehaus.mojo.signature:java18:1.0"
# 11.0.0+ require Java 17+
Expand All @@ -109,5 +115,5 @@ undertow-servlet = "io.undertow:undertow-servlet:2.3.18.Final"
# Do not update: Pinned to the last version supporting Java 8.
# See https://checkstyle.sourceforge.io/releasenotes.html#Release_10.1
checkstylejava8 = "com.puppycrawl.tools:checkstyle:9.3"
# See https://github.com/google/error-prone/releases/tag/v2.11.0
# 2.11.0+ requires JDK 11+ (See https://github.com/google/error-prone/releases/tag/v2.11.0)
errorprone-corejava8 = "com.google.errorprone:error_prone_core:2.10.0"
2 changes: 2 additions & 0 deletions servlet/jakarta/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ def migrate(String name, String inputDir, SourceSet sourceSet) {
filter { String line ->
line.replace('javax.servlet', 'jakarta.servlet')
.replace('io.grpc.servlet', 'io.grpc.servlet.jakarta')
.replace('org.eclipse.jetty.http2.parser', 'org.eclipse.jetty.http2')
.replace('org.eclipse.jetty.servlet', 'org.eclipse.jetty.ee10.servlet')
}
}
}
Expand Down
Loading