stub: Eliminate invalid test cases where different threads were calling close from the thread writing. #11822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…se from the thread writing.
ejona86
reviewed
Jan 14, 2025
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
testCancel() also looks to need fixing.
ejona86
approved these changes
Jan 15, 2025
larry-safran
added a commit
to larry-safran/grpc-java
that referenced
this pull request
Feb 5, 2025
…ng close from the thread writing. (grpc#11822) * Eliminate invalid test cases where different threads were calling close from the thread writing. * Remove multi-thread cancel/write test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.