okhttp: Per-rpc call option authority verification #11754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orityverifyokhttp
ejona86
reviewed
Dec 17, 2024
Member
ejona86
left a comment
ejona86
left a comment
There was a problem hiding this comment.
I still need to look at the core of it, but the shape looks right. These comments are mostly surface-level.
…oved setting sslEndpointAlgorithm.
This reverts commit f5b3614.
Contributor
Author
|
Yet to make the changes to use X509ExtendedTrustManager only via reflection if it is available in the class loader. |
Contributor
Author
Done. |
ejona86
reviewed
Mar 26, 2025
kannanjgithub
commented
Mar 26, 2025
ejona86
reviewed
Mar 26, 2025
ejona86
reviewed
Mar 26, 2025
ejona86
reviewed
Mar 27, 2025
ejona86
approved these changes
Mar 28, 2025
Also make sure that the failure is only the RPC-failure not a connection failure.
The checkServerTrustedCalled wasn't actually testing what it tried to; it would become true simply because of the TLS handshake. That led to searching for a proper way to test it and renaming the tests so it was clearer what was and wasn't tested which led to further test tweaks.
ejona86
requested changes
Mar 29, 2025
kannanjgithub
commented
Apr 1, 2025
ejona86
approved these changes
Apr 1, 2025
ejona86
changed the title
Sangamesh1997
pushed a commit
to Sangamesh1997/grpc-java
that referenced
this pull request
Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.