Add StatusProto.toStatusException overload to accept Throwable
#11083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @ejona86 |
ejona86
reviewed
Apr 15, 2024
panchenko
reviewed
Apr 16, 2024
panchenko
reviewed
Apr 16, 2024
|
|
||
| @Test | ||
| public void toStatusExceptionWithMetadataAndCause_shouldCaptureCause() { | ||
| RuntimeException exc = new RuntimeException("This is a test exception."); |
There was a problem hiding this comment.
probably rename exc -> cause
There was a problem hiding this comment.
Yeah, ex, exception, cause, etc would be more common, but we can live with this.
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
ejona86
approved these changes
Apr 24, 2024
larry-safran
approved these changes
Apr 24, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10900