implement ability to skip generation of javax annotation

[alexanderankin]

supercedes #10786, improves #9179 situation

[ejona86]

It's a bit weird to name this "jakarta" since it isnt' Jakarta, but sure. Let's just remove the redundant case.

[ejona86]

Just delete this case, since it is the same as the final else?

[alexanderankin]

yeah its is totally wonky but i want to make it as dead simple as possible so it is obvious what the default behavior is. not a c++ guy so i am coding for the fellow non-c++ https://grugbrain.dev

[alexanderankin]

my prediction is you will have more disgruntled souls come in here because jakarta has replaced javax and that is what everyone is using these days. since spring boot has made the move, this accounts for like vast majority of people ¯_(ツ)_/¯.

[alexanderankin]

so as consequence just structuring the code so it is obvious where to put the new code statements for jakarta

[alexanderankin]

ok looks like it finally passes - pretty mergeable apart from the bit of grossness with the if else's: lmk if its a deal breaker

[alexanderankin]

Do I need to fix the kokoro build? I can try to fix that if it's replicatable locally

[larry-safran]

No, that is not a required build.

…

On Fri, Feb 16, 2024 at 5:06 PM David Ankin ***@***.***> wrote: Do I need to fix the kokoro build? I can try to fix that if it's replicatable locally — Reply to this email directly, view it on GitHub <#10927 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AZQMCXTSETSJHQ73W2LQV3TYT77APAVCNFSM6AAAAABDMVLVIKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNBZGU3DANRTGI> . You are receiving this because your review was requested.Message ID: ***@***.***>

[ejona86]

@alexanderankin, it was a known issue that just cropped up. It is unrelated to your change. #10925

[paul8620]

When is there a release of this?

[larry-safran]

This will be part of the 1.63.0 release which is targeted for early April.

[EduardoSemanas]

@alexanderankin @ejona86 @larry-safran could you help me implement the jakarta_mode omit? Where/How should I add it? I've tried through custom options on the .proto but with no luck there, maybe I'm understanding something wrong here

[panchenko]

In gradle it looks like the following

protobuf {
    protoc { artifact = "com.google.protobuf:protoc:$Versions.protoc" }
    plugins { grpc { artifact = "io.grpc:protoc-gen-grpc-java:$Versions.grpc" } }
    generateProtoTasks {
        all()*.plugins { grpc { option 'jakarta_omit' } }
    }
}

[panchenko]

The option name is not clear enough, so I have suggested #11086.

[EduardoSemanas]

@panchenko thank you so much. I'm using maven (probably should have mentioned it before) and having some trouble finding out how to specify generateProtoTasks with it. Do you have any idea how it should be done?

[EduardoSemanas]

UPDATE: I was able to implement it using maven like so:

<plugin>
    <groupId>org.xolstice.maven.plugins</groupId>
    <artifactId>protobuf-maven-plugin</artifactId>
    <version>0.6.1</version>
    <configuration>
        <protocArtifact>com.google.protobuf:protoc:3.12.0:exe:${os.detected.classifier}</protocArtifact>
        <pluginId>grpc-java</pluginId>
        <pluginArtifact>io.grpc:protoc-gen-grpc-java:${grpc.version}:exe:${os.detected.classifier}
        </pluginArtifact>
    </configuration>
    <executions>
        <execution>
            <configuration>
                <pluginParameter>
                    jakarta_omit
                </pluginParameter>
            </configuration>
            <goals>
                <goal>compile</goal>
                <goal>compile-custom</goal>
            </goals>
        </execution>
    </executions>
</plugin>

[alexanderankin]

UPDATE: I was able to implement it using maven like so:

@EduardoSemanas - the option name has changed as per #11086 - if you want to update your example

--- before.xml	2024-04-19 09:46:24.169520648 -0400
+++ after.xml	2024-04-19 09:46:43.677325583 -0400
@@ -12,7 +12,7 @@
         <execution>
             <configuration>
                 <pluginParameter>
-                    jakarta_omit
+                    @generated=omit
                 </pluginParameter>
             </configuration>
             <goals>

@panchenko if you can update yours as well:

--- before.gradle	2024-04-19 09:48:05.884466658 -0400
+++ after.gradle	2024-04-19 09:48:19.112323278 -0400
@@ -2,6 +2,6 @@
     protoc { artifact = "com.google.protobuf:protoc:$Versions.protoc" }
     plugins { grpc { artifact = "io.grpc:protoc-gen-grpc-java:$Versions.grpc" } }
     generateProtoTasks {
-        all()*.plugins { grpc { option 'jakarta_omit' } }
+        all()*.plugins { grpc { option '@generated=omit' } }
     }
 }

[ah-quant]

I haven't tested it yet, but as a supporting pointer for Bazel users:
Adding this to .bazelrc looks right to me: build --protocopt=--grpc-java_opt=@generated=omit

EDIT: that was wrong. I created #11226