Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Excess contention in ManagedChannelImpl.exitIdleMode #2119

Closed
carl-mastrangelo opened this issue Aug 2, 2016 · 1 comment
Closed

Excess contention in ManagedChannelImpl.exitIdleMode #2119

carl-mastrangelo opened this issue Aug 2, 2016 · 1 comment
Assignees
@ejona86
Labels
performance

Comments

@carl-mastrangelo
Copy link
Contributor

Each RPC needs a transport, and thus calls ManagedChannelImpl's transport provider. This tries to make the transport wake up, but does so under a lock. Profiling reveals a high amount of contention on this lock. If possible we should look at eliding the lock and using a volatile read to get the loadbalancer out of it.

cc @zhangkun83
@zhangkun83 zhangkun83 self-assigned this Aug 3, 2016
@carl-mastrangelo
Copy link
Contributor Author

FYI, adding a local fix shows a significant improvement, so this should be treated more importantly than the other contention issues, but less than #2118

@ejona86 ejona86 assigned ejona86 and unassigned zhangkun83 Sep 10, 2016
ejona86 added a commit to ejona86/grpc-java that referenced this issue Sep 10, 2016
@ejona86
core: Use grace period to avoid exitIdleMode in fast path
63d3470 
Fixes grpc#2119
@ejona86 ejona86 mentioned this issue Sep 10, 2016
Merged
ejona86 added a commit to ejona86/grpc-java that referenced this issue Oct 25, 2016
@ejona86
core: Use grace period to avoid exitIdleMode in fast path
496a621 
Fixes grpc#2119
@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2018
fixmebot bot referenced this issue in aomsw13/develop_test Apr 12, 2021
@testfixme
Update readme.md
70b8890
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ejona86 ejona86

Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ejona86 @carl-mastrangelo @zhangkun83