notes on addressing FilterChainMatch issue

grpc · Feb 7, 2025 · 0804b55 · 0804b55
1 parent 9b3306d
commit 0804b55
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java b/xds/src/main/java/io/grpc/xds/XdsServerWrapper.java
@@ -116,8 +116,12 @@ public void uncaughtException(Thread t, Throwable e) {
   private volatile Server delegate;
 
   // Must be updated in the sync context.
-  // TODO(sergiitk): [QUESTION] should this be per filter chain too?
+  // TODO(sergiitk): [QUESTION] consider the implication of filterchain equality, during updates.
+  // how to identify this is the same filter chain
+  // - based on index?
+  // - based on FilterChainMatch?
   private final HashMap<String, Filter> activeFilters = new HashMap<>();
+  // private final HashMap<FilterChain, HashMap<String, Filter>> activeFilters = new HashMap<>();
 
   XdsServerWrapper(
       String listenerAddress,