Skip to content

xds/rbac: use net.SplitHostPort in IP matchers to handle ip:port addresses#8992

Closed
instantraaamen wants to merge 3 commits into
grpc:masterfrom
instantraaamen:fix/rbac-ip-matcher-splithost
Closed

xds/rbac: use net.SplitHostPort in IP matchers to handle ip:port addresses#8992
instantraaamen wants to merge 3 commits into
grpc:masterfrom
instantraaamen:fix/rbac-ip-matcher-splithost

xds/rbac: fix gofmt indentation in ip_matcher_test.go

2dd19b3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 25, 2026 in 1s

82.94% (-0.11%) compared to 12e91dd

View this Pull Request on Codecov

82.94% (-0.11%) compared to 12e91dd

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.94%. Comparing base (12e91dd) to head (2dd19b3).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8992      +/-   ##
==========================================
- Coverage   83.04%   82.94%   -0.11%     
==========================================
  Files         411      411              
  Lines       32892    32900       +8     
==========================================
- Hits        27316    27288      -28     
- Misses       4181     4206      +25     
- Partials     1395     1406      +11     
Files with missing lines Coverage Δ
internal/xds/rbac/matchers.go 78.36% <100.00%> (+0.86%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.