Skip to content

xds/rbac: add additional handling for addresses with ports - #8990

Merged
mbissa merged 2 commits into
grpc:masterfrom
mbissa:xds-rbac-handle-ipaddress-port
Mar 26, 2026
Merged

xds/rbac: add additional handling for addresses with ports#8990
mbissa merged 2 commits into
grpc:masterfrom
mbissa:xds-rbac-handle-ipaddress-port

review comments

8b2575b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 26, 2026 in 0s

82.93% (-0.49%) compared to b6597b3

View this Pull Request on Codecov

82.93% (-0.49%) compared to b6597b3

Details

Codecov Report

❌ Patch coverage is 50.00000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.93%. Comparing base (b6597b3) to head (8b2575b).
⚠️ Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
internal/xds/rbac/matchers.go 50.00% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8990      +/-   ##
==========================================
- Coverage   83.42%   82.93%   -0.49%     
==========================================
  Files         410      411       +1     
  Lines       32572    32941     +369     
==========================================
+ Hits        27172    27319     +147     
- Misses       4030     4209     +179     
- Partials     1370     1413      +43     
Files with missing lines Coverage Δ
internal/xds/rbac/matchers.go 75.71% <50.00%> (-1.79%) ⬇️

... and 65 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.