xds: fix copy-paste bug in WeightExpirationPeriod config#8915
Merged
arjan-bal merged 2 commits intogrpc:masterfrom Feb 24, 2026
Merged
xds: fix copy-paste bug in WeightExpirationPeriod config#8915arjan-bal merged 2 commits intogrpc:masterfrom
arjan-bal merged 2 commits intogrpc:masterfrom
Conversation
Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8915 +/- ##
==========================================
+ Coverage 80.40% 83.19% +2.79%
==========================================
Files 416 417 +1
Lines 33495 32940 -555
==========================================
+ Hits 26930 27406 +476
+ Misses 4682 4110 -572
+ Partials 1883 1424 -459
🚀 New features to boost your workflow:
|
Pranjali-2501
approved these changes
Feb 20, 2026
arjan-bal
reviewed
Feb 23, 2026
arjan-bal
approved these changes
Feb 24, 2026
Contributor
arjan-bal
left a comment
There was a problem hiding this comment.
LGTM, thank you for the contribution!
This was referenced Apr 23, 2026
Closed
Closed
fix(deps): vuln minor upgrades — 11 packages (minor: 7 · patch: 4) [server]
DataDog/temporalio-ui#27
Closed
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a copy-paste bug in the xDS client-side weighted round robin converter where GetBlackoutPeriod() was incorrectly called twice - once for BlackoutPeriod (correct) and once for WeightExpirationPeriod (incorrect).
BlackoutPeriod: The duration after startup during which weight updates are ignored
WeightExpirationPeriod: The duration after which backend weights expire if not updated
RELEASE NOTES: