Skip to content

xds: fix copy-paste bug in WeightExpirationPeriod config#8915

Merged
arjan-bal merged 2 commits intogrpc:masterfrom
gregbarasch:fix-weight-expiration-copy-paste
Feb 24, 2026
Merged

xds: fix copy-paste bug in WeightExpirationPeriod config#8915
arjan-bal merged 2 commits intogrpc:masterfrom
gregbarasch:fix-weight-expiration-copy-paste

Conversation

@gregbarasch
Copy link
Copy Markdown
Contributor

@gregbarasch gregbarasch commented Feb 20, 2026

This PR fixes a copy-paste bug in the xDS client-side weighted round robin converter where GetBlackoutPeriod() was incorrectly called twice - once for BlackoutPeriod (correct) and once for WeightExpirationPeriod (incorrect).

BlackoutPeriod: The duration after startup during which weight updates are ignored
WeightExpirationPeriod: The duration after which backend weights expire if not updated

RELEASE NOTES:

  • xds: Fixed incorrect proto field access in weighted round robin configuration.

Signed-off-by: Greg Barasch <gregbarasch@gmail.com>
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Feb 20, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.19%. Comparing base (c1a9239) to head (dbe6368).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8915      +/-   ##
==========================================
+ Coverage   80.40%   83.19%   +2.79%     
==========================================
  Files         416      417       +1     
  Lines       33495    32940     -555     
==========================================
+ Hits        26930    27406     +476     
+ Misses       4682     4110     -572     
+ Partials     1883     1424     -459     
Files with missing lines Coverage Δ
...xds/xdsclient/xdslbregistry/converter/converter.go 75.23% <100.00%> (+1.90%) ⬆️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread internal/xds/xdsclient/xdslbregistry/converter/converter.go
@arjan-bal arjan-bal assigned gregbarasch and unassigned arjan-bal Feb 23, 2026
@gregbarasch gregbarasch removed their assignment Feb 24, 2026
@arjan-bal arjan-bal self-assigned this Feb 24, 2026
Copy link
Copy Markdown
Contributor

@arjan-bal arjan-bal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution!

@arjan-bal arjan-bal merged commit 7bc5785 into grpc:master Feb 24, 2026
14 checks passed
This was referenced Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants