Merged
Conversation
…rpc#8874) This resolves an issue where below log statement keeps printing repeatedly: "ERROR: [otel-plugin] ctx passed into client side stats handler metrics event handling has no client attempt data present". When new stream is created for health/orca producers, stats and tracing is not setup. However, this fact is ignored during RPC and an error logs is printed to denote that stats cannot be handled. We will enable stream to have its own reference to the stats handler and only process per RPC implementation when it is present (like in case of regular data streams). Internal issue: b/385685802 RELEASE NOTES: * stats: only process RPC stats/tracing in health and ORCA producers if a handler is configured, preventing unnecessary error logging
Contributor
|
Please fix the PR description. Only keep the release notes and a link to the original PR. |
Contributor
|
Please update the milestone to 1.79, otherwise the release notes will show up in the 1.80 release. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.79.x #8904 +/- ##
===========================================
- Coverage 83.26% 82.56% -0.70%
===========================================
Files 414 414
Lines 32743 32748 +5
===========================================
- Hits 27262 27037 -225
+ Misses 4074 4053 -21
- Partials 1407 1658 +251
🚀 New features to boost your workflow:
|
Contributor
|
Please change the PR title to the format: |
mbissa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry picks PR into 1.79.x
RELEASE NOTES: