Skip to content

*: Implementation of weighted random shuffling (A113)#8864

Merged
easwars merged 8 commits into
grpc:masterfrom
easwars:directpath_soft_affinity
Jan 30, 2026
Merged

*: Implementation of weighted random shuffling (A113)#8864
easwars merged 8 commits into
grpc:masterfrom
easwars:directpath_soft_affinity

second round of review comments from Arjan

3f4487d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 30, 2026 in 1s

83.17% (+0.75%) compared to 69b542a

View this Pull Request on Codecov

83.17% (+0.75%) compared to 69b542a

Details

Codecov Report

❌ Patch coverage is 92.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.17%. Comparing base (69b542a) to head (3f4487d).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
balancer/pickfirst/pickfirst.go 92.59% 1 Missing and 1 partial ⚠️
...rnal/xds/balancer/clusterresolver/configbuilder.go 91.30% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8864      +/-   ##
==========================================
+ Coverage   82.42%   83.17%   +0.75%     
==========================================
  Files         414      414              
  Lines       32750    32755       +5     
==========================================
+ Hits        26994    27245     +251     
+ Misses       4096     4090       -6     
+ Partials     1660     1420     -240     
Files with missing lines Coverage Δ
balancer/pickfirst/internal/internal.go 100.00% <ø> (ø)
internal/envconfig/envconfig.go 100.00% <ø> (+26.66%) ⬆️
balancer/pickfirst/pickfirst.go 89.28% <92.59%> (-0.34%) ⬇️
...rnal/xds/balancer/clusterresolver/configbuilder.go 92.42% <91.30%> (-1.61%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.