balancer: introduce env flag for case-sensitive registry#8837
balancer: introduce env flag for case-sensitive registry#8837Pranjali-2501 merged 2 commits intogrpc:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8837 +/- ##
==========================================
- Coverage 83.22% 82.99% -0.24%
==========================================
Files 417 414 -3
Lines 32920 32783 -137
==========================================
- Hits 27397 27207 -190
Misses 4108 4108
- Partials 1415 1468 +53
🚀 New features to boost your workflow:
|
|
I think a couple of things need to be done before we can make a change like this that can break our users:
Also check internal usages in google3 if there are balancers that need to be changed. |
|
Please update the PR description and the title. Also, the related needs to stay open so that we do the follow-up activities (changing the env var to true by default, and getting rid of it). |
|
@dfawley : Do you have a suggestion for the name of the env var? I suggested |
Maybe that's a feature? :) I don't think the name for this is too important. We'll be deleting it (one way or another) after a few releases? And nobody should be relying on it for anything more than a workaround? |
Yes, we will be deleting it after few releases. |
Part of grpc#5288 Follow up of PR: grpc#6647 This PR introduces the `GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES` environment variable to transition balancer registries to be case-sensitive. **Default Behavior**: * The env var is disabled by default. * The registry remains case-insensitive (legacy behavior) and a warning is logged if a balancer name contains uppercase letters, notifying users of the upcoming change. RELEASE NOTES: * balancer: grpc will log a warning if balancer registries are used with uppercase letter(s).
…RIES` by default (#9017) Part of #5288 Follow up of PR: #8837 This PR enabled the env variable GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES by default to transition balancer registries to be case-sensitive. RELEASE NOTES: * balancer: balancer registries are now case-sensitive by default. Disable GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIES env var to temporarily revert this behavior.
Part of #5288
Follow up of PR: #6647
This PR introduces the
GRPC_GO_EXPERIMENTAL_CASE_SENSITIVE_BALANCER_REGISTRIESenvironment variable to transition balancer registries to be case-sensitive.Default Behavior:
* The env var is disabled by default.
* The registry remains case-insensitive (legacy behavior) and a warning is logged if a balancer name contains uppercase letters, notifying users of the upcoming change.
RELEASE NOTES: