Skip to content

Conversation

@arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Jan 7, 2026

Presently, the DNS resolver relies on the resolver_wrapper to convert addresses to endpoints and populate the ResolverState.Endpoints field. However, when resolving Logical DNS cluster hostnames in xDS, the DNS resolver is used without the resolver_wrapper. Since the dual-stack changes have been merged, we plan to clean up code that uses the Addresses field and instead rely on the Endpoints field always being set. To support this, the DNS resolver must now handle the conversion of addresses to endpoints internally.

This change also fixes a bug in the dependency manager where it doesn't read the endpoints if the resolver provides endpoints directly instead of giving addresses.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added this to the 1.79 Release milestone Jan 7, 2026
@arjan-bal arjan-bal added Type: Internal Cleanup Refactors, etc Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. labels Jan 7, 2026
@arjan-bal arjan-bal changed the title dns: Set Endpoints in resolver updates dns: set Endpoints in resolver updates Jan 7, 2026
@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 83.36%. Comparing base (900ffa9) to head (cd79de4).
⚠️ Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
internal/xds/xdsdepmgr/xds_dependency_manager.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8812      +/-   ##
==========================================
+ Coverage   83.25%   83.36%   +0.10%     
==========================================
  Files         417      417              
  Lines       32978    32928      -50     
==========================================
- Hits        27457    27450       -7     
+ Misses       4106     4085      -21     
+ Partials     1415     1393      -22     
Files with missing lines Coverage Δ
internal/resolver/dns/dns_resolver.go 90.27% <100.00%> (+0.37%) ⬆️
internal/xds/xdsdepmgr/xds_dependency_manager.go 80.18% <50.00%> (-1.16%) ⬇️

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal assigned easwars and eshitachandwani and unassigned easwars and arjan-bal Jan 7, 2026
@eshitachandwani eshitachandwani removed their assignment Jan 8, 2026
@easwars easwars assigned arjan-bal and unassigned easwars Jan 8, 2026
@arjan-bal arjan-bal assigned easwars and unassigned arjan-bal Jan 9, 2026
@eshitachandwani
Copy link
Member

The TestRouteConfigResource failing test is due to the point 2 mentioned in this PR :
#8805
The PR also fixes it.

@easwars easwars assigned arjan-bal and unassigned easwars Jan 15, 2026
@arjan-bal arjan-bal merged commit e15b867 into grpc:master Jan 16, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Resolvers/Balancers Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities. Type: Internal Cleanup Refactors, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants