-
Notifications
You must be signed in to change notification settings - Fork 4.6k
dns: set Endpoints in resolver updates #8812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+234
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8812 +/- ##
==========================================
+ Coverage 83.25% 83.36% +0.10%
==========================================
Files 417 417
Lines 32978 32928 -50
==========================================
- Hits 27457 27450 -7
+ Misses 4106 4085 -21
+ Partials 1415 1393 -22
🚀 New features to boost your workflow:
|
eshitachandwani
approved these changes
Jan 8, 2026
easwars
reviewed
Jan 8, 2026
1ec99df to
cd79de4
Compare
Member
|
The TestRouteConfigResource failing test is due to the point 2 mentioned in this PR : |
easwars
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Resolvers/Balancers
Includes LB policy & NR APIs, resolver/balancer/picker wrappers, LB policy impls and utilities.
Type: Internal Cleanup
Refactors, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, the DNS resolver relies on the
resolver_wrapperto convert addresses to endpoints and populate theResolverState.Endpointsfield. However, when resolving Logical DNS cluster hostnames in xDS, the DNS resolver is used without theresolver_wrapper. Since the dual-stack changes have been merged, we plan to clean up code that uses theAddressesfield and instead rely on theEndpointsfield always being set. To support this, the DNS resolver must now handle the conversion of addresses to endpoints internally.This change also fixes a bug in the dependency manager where it doesn't read the endpoints if the resolver provides endpoints directly instead of giving addresses.
RELEASE NOTES: N/A