Skip to content

transport: Remove unused return value from connect()#8787

Merged
eshitachandwani merged 1 commit intogrpc:masterfrom
twz123:clientconn-connect-no-retval
Jan 8, 2026
Merged

transport: Remove unused return value from connect()#8787
eshitachandwani merged 1 commit intogrpc:masterfrom
twz123:clientconn-connect-no-retval

Conversation

@twz123
Copy link
Contributor

@twz123 twz123 commented Dec 22, 2025

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.35%. Comparing base (4046676) to head (08d9a68).
⚠️ Report is 11 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8787      +/-   ##
==========================================
- Coverage   83.42%   83.35%   -0.07%     
==========================================
  Files         418      418              
  Lines       32897    32896       -1     
==========================================
- Hits        27443    27422      -21     
- Misses       4069     4082      +13     
- Partials     1385     1392       +7     
Files with missing lines Coverage Δ
clientconn.go 90.43% <100.00%> (-0.25%) ⬇️

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mbissa mbissa assigned mbissa and eshitachandwani and unassigned mbissa Dec 24, 2025
@eshitachandwani eshitachandwani added this to the 1.79 Release milestone Jan 2, 2026
@eshitachandwani eshitachandwani self-requested a review January 2, 2026 06:25
@mbissa
Copy link
Contributor

mbissa commented Jan 8, 2026

The title should be changed to transport instead of clientconn

@mbissa mbissa assigned eshitachandwani and unassigned mbissa Jan 8, 2026
@eshitachandwani eshitachandwani changed the title clientconn: Remove unused return value from connect() transport: Remove unused return value from connect() Jan 8, 2026
@eshitachandwani eshitachandwani merged commit 85ede8e into grpc:master Jan 8, 2026
15 of 17 checks passed
@twz123 twz123 deleted the clientconn-connect-no-retval branch January 13, 2026 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants