-
Notifications
You must be signed in to change notification settings - Fork 4.6k
xds: Add cluster endpoint watchers to depndency manager #8744
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8744 +/- ##
==========================================
- Coverage 83.39% 83.34% -0.05%
==========================================
Files 419 418 -1
Lines 32566 32897 +331
==========================================
+ Hits 27159 27419 +260
- Misses 4023 4084 +61
- Partials 1384 1394 +10
🚀 New features to boost your workflow:
|
|
Can you also please check the codecov report here: #8744 (comment) to see if there are any valid lines that are missing test coverage. Thanks. |
| {ID: clients.Locality{ | ||
| Region: "region-1", | ||
| Zone: "zone-1", | ||
| SubZone: "subzone-1", | ||
| }, | ||
| Endpoints: []xdsresource.Endpoint{ | ||
| { | ||
| Addresses: []string{addr}, | ||
| HealthStatus: xdsresource.EndpointHealthStatusUnknown, | ||
| Weight: 1, | ||
| }, | ||
| }, | ||
| Weight: 1}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to be fixed yet.
| {ID: clients.Locality{ | ||
| Region: "region-1", | ||
| Zone: "zone-1", | ||
| SubZone: "subzone-1", | ||
| }, | ||
| Endpoints: []xdsresource.Endpoint{ | ||
| { | ||
| Addresses: []string{"localhost:8081"}, | ||
| HealthStatus: xdsresource.EndpointHealthStatusUnknown, | ||
| Weight: 1, | ||
| }, | ||
| }, | ||
| Weight: 1}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hasn't been fixed yet.
|
I made a small refactoring commit to split the I also added the |
easwars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of my comments might be outdated as this point, as I pushed a couple of commits for more generics and some simplification around the dns resolver.
This is part of A74 implementation which add CDS/EDS/DNS watchers to the dependency manager. It also adds a temporary flag that is disabled by default so that it is not used in the current RPC paths , but enabled in the dependency manager tests.
RELEASE NOTES: None