Skip to content

deps: bump Go version in Dockerfiles - #8522

Merged
arjan-bal merged 4 commits into
grpc:masterfrom
stanley-cheung:fix-o11y-test
Aug 19, 2025
Merged

deps: bump Go version in Dockerfiles#8522
arjan-bal merged 4 commits into
grpc:masterfrom
stanley-cheung:fix-o11y-test

Conversation

@stanley-cheung

@stanley-cheung stanley-cheung commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Aug 18, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.83%. Comparing base (9ac0ec8) to head (f76ce3a).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8522      +/-   ##
==========================================
+ Coverage   81.82%   81.83%   +0.01%     
==========================================
  Files         413      412       -1     
  Lines       40518    40518              
==========================================
+ Hits        33153    33159       +6     
+ Misses       5989     5962      -27     
- Partials     1376     1397      +21     

see 232 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal

Copy link
Copy Markdown
Contributor

It looks like we've also broken the PSM interop tests. @stanley-cheung, could you please bump the Go version to Go 1.25 on all the Dockerfiles? This would give us more time before we need to update the version again.

Reference PR: https://github.com/grpc/grpc-go/pull/7629/files

@arjan-bal
arjan-bal requested review from arjan-bal and dfawley August 19, 2025 05:45
@arjan-bal arjan-bal added this to the 1.76 Release milestone Aug 19, 2025
@arjan-bal arjan-bal added Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Testing labels Aug 19, 2025
@stanley-cheung

Copy link
Copy Markdown
Contributor Author

It looks like we've also broken the PSM interop tests. @stanley-cheung, could you please bump the Go version to Go 1.25 on all the Dockerfiles? This would give us more time before we need to update the version again.

Reference PR: https://github.com/grpc/grpc-go/pull/7629/files

Done. Thanks for the reference.

Comment thread interop/observability/Dockerfile Outdated
#

FROM golang:1.23-bullseye as build
FROM golang:1.25-bullseye as build

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like golang:1.25-bullseye is not published yet.

$ docker pull golang:1.25-bullseye
Error response from daemon: manifest for golang:1.25-bullseye not found: manifest unknown: manifest unknown

$ docker pull golang:1.24-bullseye
1.24-bullseye: Pulling from library/golang
078965fc7cf3: Pull complete 
8620e616831b: Pull complete 
99bdf4e3059e: Pull complete 
79e3925f0bdb: Pull complete 
9a940d118df6: Pull complete 
25ac2e409764: Pull complete 
4f4fb700ef54: Pull complete 
Digest: sha256:2cdc80dc25edcb96ada1654f73092f2928045d037581fa4aa7c40d18af7dd85a
Status: Downloaded newer image for golang:1.24-bullseye
docker.io/library/golang:1.24-bullseye

We can use golang:1.25-alpine here also. I tried building with the alpine image and it worked.

TAG_NAME="gcr.io/a/b"
docker build --no-cache -t ${TAG_NAME} -f ./interop/observability/Dockerfile .

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed thanks.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this Dockerfile is using bullseye because the entrypoint is a bash script. Since alpine images don't have Bash, we'll need to use golang:1.24-bullseye instead. My apologies for the incorrect suggestion

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. I had the tinkering something was off - you got it right.

@arjan-bal arjan-bal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arjan-bal arjan-bal changed the title Fix observability test dockerfile deps: bump Go version in Dockerfiles Aug 19, 2025
@arjan-bal
arjan-bal merged commit fa0d658 into grpc:master Aug 19, 2025
16 checks passed
@stanley-cheung
stanley-cheung deleted the fix-o11y-test branch August 19, 2025 21:32
@stanley-cheung

Copy link
Copy Markdown
Contributor Author

Can confirm that the grpc observability test are back to passing after this fix. Thanks

dimpavloff pushed a commit to dimpavloff/grpc-go that referenced this pull request Aug 22, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Area: Testing Includes tests and testing utilities that we have for unit and e2e tests within our repo. Type: Testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants