stats: change non-standard units to annotations#8481
Merged
arjan-bal merged 1 commit intogrpc:masterfrom Aug 1, 2025
Merged
Conversation
a75e77c to
9b04f93
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8481 +/- ##
=======================================
Coverage 82.35% 82.35%
=======================================
Files 413 413
Lines 40518 40518
=======================================
+ Hits 33368 33369 +1
+ Misses 5781 5779 -2
- Partials 1369 1370 +1
🚀 New features to boost your workflow:
|
dfawley
approved these changes
Jul 31, 2025
dimpavloff
pushed a commit
to dimpavloff/grpc-go
that referenced
this pull request
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gRPC Go has been specifying units as non-standard values such as
callandendpointinstead of using annotations like{call}. Based on the metric naming conventions anything enclosed in curly braces is an annotation and in the absence of a prefix, the unit is1. The gRPC docs also mention that non-standard units need to be enclosed in curly braces: https://grpc.io/docs/guides/opentelemetry-metrics/#per-call-metrics.This bug was caught due to a regression in the otel prometheus exporter: #8479
RELEASE NOTES:
callandendpointin curly braces to comply with UCUM and gRPC OpenTelemetry guidelines.