Skip to content

roundrobin: Remove unnecessary ExitIdle override#8390

Merged
arjan-bal merged 1 commit intogrpc:masterfrom
arjan-bal:cleanup-exit-idle
Jun 11, 2025
Merged

roundrobin: Remove unnecessary ExitIdle override#8390
arjan-bal merged 1 commit intogrpc:masterfrom
arjan-bal:cleanup-exit-idle

Conversation

@arjan-bal
Copy link
Contributor

This override was introduced recently in #8367. It's not necessary.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added this to the 1.74 Release milestone Jun 10, 2025
@arjan-bal arjan-bal added the Type: Internal Cleanup Refactors, etc label Jun 10, 2025
@arjan-bal arjan-bal requested a review from easwars June 10, 2025 06:18
@codecov
Copy link

codecov bot commented Jun 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.33%. Comparing base (d2e8366) to head (d680c30).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8390      +/-   ##
==========================================
+ Coverage   82.17%   82.33%   +0.15%     
==========================================
  Files         419      419              
  Lines       42065    42063       -2     
==========================================
+ Hits        34567    34631      +64     
+ Misses       6023     5980      -43     
+ Partials     1475     1452      -23     
Files with missing lines Coverage Δ
balancer/roundrobin/roundrobin.go 100.00% <ø> (ø)

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal merged commit 57400b4 into grpc:master Jun 11, 2025
23 of 24 checks passed
@arjan-bal arjan-bal deleted the cleanup-exit-idle branch June 11, 2025 16:26
vinothkumarr227 pushed a commit to vinothkumarr227/grpc-go that referenced this pull request Jun 19, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants