xds: generic xds client ads stream tests#8307
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8307 +/- ##
==========================================
+ Coverage 82.22% 82.30% +0.07%
==========================================
Files 419 419
Lines 41954 42025 +71
==========================================
+ Hits 34497 34589 +92
+ Misses 5995 5979 -16
+ Partials 1462 1457 -5
🚀 New features to boost your workflow:
|
|
|
||
| // SetStreamBackOffForTesting override the default stream backoff function | ||
| // with provided function. | ||
| func (c *XDSClient) SetStreamBackOffForTesting(streamBackoff func(int) time.Duration) { |
There was a problem hiding this comment.
Please put this in an internal subdirectory and set it to an unexported function here.
There was a problem hiding this comment.
Done for both expiry and backoff
900a1bf to
ffe6b75
Compare
ffe6b75 to
b9afcfa
Compare
b9afcfa to
72bdea5
Compare
| @@ -0,0 +1,275 @@ | |||
| /* | |||
| * | |||
| * Copyright 2024 gRPC authors. | |||
There was a problem hiding this comment.
Is this moved from elsewhere? You have several "new" files with 2024, so unless they're copies, please update.
There was a problem hiding this comment.
yeah this is copied from internal and then modified. Similar to how done in previous PRs
There was a problem hiding this comment.
I see. That should make it a lot easier to review @easwars.
There was a problem hiding this comment.
These tests needs to be deleted from internal xdsclient as part of migration PR #8310 as they need to override internal resource watching implementation.
xds/internal/clients/xdsclient/test/ads_stream_flow_control_test.go
Outdated
Show resolved
Hide resolved
xds/internal/clients/xdsclient/test/ads_stream_flow_control_test.go
Outdated
Show resolved
Hide resolved
3956e5b to
19248d1
Compare
RELEASE NOTES: None