interop: Wait for server to become ready in alts tests - #8141
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8141 +/- ##
==========================================
- Coverage 82.32% 82.26% -0.07%
==========================================
Files 388 389 +1
Lines 39016 39125 +109
==========================================
+ Hits 32121 32187 +66
- Misses 5574 5607 +33
- Partials 1321 1331 +10 |
janardhanvissa
pushed a commit
to janardhanvissa/grpc-go
that referenced
this pull request
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #7970, the alts client was changed from using
grpc.Dialwithgrpc.WithBlocktogrpc.NewClientwithoutWithBlock. The tests that run in g3 don't wait for the server to start before starting the client. If WithBlock is not used, the client enters TRANSIENT_FAILURE after getting aconnection refusederror in the first connection attempt. This PR addsgrpc.WaitForReadywhile making the RPC to restore the previous behaviour.RELEASE NOTES: N/A