xds: Enable dualstack flag - #8134
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.71.x #8134 +/- ##
===========================================
- Coverage 82.39% 82.25% -0.15%
===========================================
Files 387 387
Lines 38954 38954
===========================================
- Hits 32096 32041 -55
- Misses 5554 5596 +42
- Partials 1304 1317 +13 |
|
Why do we want to enable only one of the two flags? |
All petiole policies use the new pickfirst for delegation. The only user-visible benefit of toggling the default pickfirst would be enabling Happy Eyeballs with a standalone pickfirst. After discussing with Doug and Mark, we decided it's acceptable to advertise xDS Dualstack support without changing the default pickfirst since known xDS pickfirst users do not want to use Dualstack. Most gRPC users rely on the default pickfirst. By delaying its adoption as the default to a future release, we allow time to gather feedback from internal users and those using the master branch. |
The flag was enabled in master as part of #8126. This PR enabled only the xDS endpoints support, leaving the new pickfirst policy flag disabled.
RELEASE NOTES: