Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

credentials: Support ALTSPerRPCCreds in DefaultCredentialsOptions #7775

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

rockspore
Copy link
Contributor

@rockspore rockspore commented Oct 24, 2024

RELEASE NOTES: none

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

Attention: Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.

Project coverage is 81.20%. Comparing base (f8e5d8f) to head (c5db6fb).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
credentials/google/google.go 70.58% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7775      +/-   ##
==========================================
- Coverage   81.32%   81.20%   -0.13%     
==========================================
  Files         368      368              
  Lines       36779    36799      +20     
==========================================
- Hits        29912    29883      -29     
- Misses       5635     5666      +31     
- Partials     1232     1250      +18     
Files with missing lines Coverage Δ
credentials/google/google.go 77.02% <70.58%> (+1.58%) ⬆️

... and 23 files with indirect coverage changes

@rockspore rockspore marked this pull request as ready for review October 24, 2024 22:02
@rockspore
Copy link
Contributor Author

@dfawley This is for the ALTS token design. The Java equivalent is grpc/grpc-java#11634. Could you help review this PR?

@arjan-bal arjan-bal added the Type: Security A bug or other problem affecting security label Oct 25, 2024
@arjan-bal arjan-bal added this to the 1.69 Release milestone Oct 25, 2024
@@ -39,6 +39,9 @@ var logger = grpclog.Component("credentials")
type DefaultCredentialsOptions struct {
// PerRPCCreds is a per RPC credentials that is passed to a bundle.
PerRPCCreds credentials.PerRPCCredentials
// ALTSRPCCreds is a per RPC credentials that, if specified, will supercede
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name should match

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch. Fixed.

@dfawley dfawley assigned rockspore and unassigned dfawley Oct 25, 2024
@rockspore rockspore changed the title Support ALTSPerRPCCreds in DefaultCredentialsOptions credentials: Support ALTSPerRPCCreds in DefaultCredentialsOptions Oct 25, 2024
@rockspore rockspore merged commit cb32937 into grpc:master Oct 25, 2024
16 checks passed
@rockspore rockspore deleted the gdcc branch October 25, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Security A bug or other problem affecting security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants