-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
credentials: Support ALTSPerRPCCreds in DefaultCredentialsOptions #7775
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7775 +/- ##
==========================================
- Coverage 81.32% 81.20% -0.13%
==========================================
Files 368 368
Lines 36779 36799 +20
==========================================
- Hits 29912 29883 -29
- Misses 5635 5666 +31
- Partials 1232 1250 +18
|
@dfawley This is for the ALTS token design. The Java equivalent is grpc/grpc-java#11634. Could you help review this PR? |
credentials/google/google.go
Outdated
@@ -39,6 +39,9 @@ var logger = grpclog.Component("credentials") | |||
type DefaultCredentialsOptions struct { | |||
// PerRPCCreds is a per RPC credentials that is passed to a bundle. | |||
PerRPCCreds credentials.PerRPCCredentials | |||
// ALTSRPCCreds is a per RPC credentials that, if specified, will supercede |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name should match
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch. Fixed.
RELEASE NOTES: none