Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds/resolver: add a way to specify the xDS client to use for testing purposes #7771

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 23, 2024

#a71-xds-fallback
#xdsclient-refactor
Addresses #6902

This PR adds a way to specify the exact xDS client to be used by the xDS resolver. Currently we only have a way of specifying the bootstrap configuration to use.

This change is required for fallback tests where we need to be able to configure xDS clients with options (like idle authority timeout) that are not part of the bootstrap configuration.

Subsequent PRs will use this functionality.

RELEASE NOTES: none

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.29%. Comparing base (8212cf0) to head (5355798).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
xds/internal/resolver/xds_resolver.go 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7771      +/-   ##
==========================================
- Coverage   81.40%   81.29%   -0.11%     
==========================================
  Files         368      368              
  Lines       36768    36775       +7     
==========================================
- Hits        29932    29898      -34     
- Misses       5607     5643      +36     
- Partials     1229     1234       +5     
Files with missing lines Coverage Δ
xds/internal/resolver/xds_resolver.go 77.53% <33.33%> (-1.40%) ⬇️

... and 19 files with indirect coverage changes

@purnesh42H
Copy link
Contributor

This change is required for fallback tests where we need to be able to configure xDS clients with options (like idle authority timeout) that are not part of the bootstrap configuration.

Why do we not have that in bootstrap configuration?

Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@easwars
Copy link
Contributor Author

easwars commented Oct 24, 2024

Why do we not have that in bootstrap configuration?

That is not something that is visible to our users. This is not a configurable option. The only reason I want to make it configurable is for testing. And I prefer e2e tests, so we need to way to inject this.

@easwars easwars merged commit c4c8b11 into grpc:master Oct 24, 2024
15 checks passed
@easwars easwars deleted the xds_resolver_for_testing branch October 24, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants