Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdsclient: implementation of the xdsChannel #7757
xdsclient: implementation of the xdsChannel #7757
Changes from 4 commits
29b4b99
75f27cd
50ab1af
01845ef
c0bd002
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 154 in xds/internal/xdsclient/channel.go
Codecov / codecov/patch
xds/internal/xdsclient/channel.go#L151-L154
Check warning on line 166 in xds/internal/xdsclient/channel.go
Codecov / codecov/patch
xds/internal/xdsclient/channel.go#L163-L166
Check warning on line 178 in xds/internal/xdsclient/channel.go
Codecov / codecov/patch
xds/internal/xdsclient/channel.go#L175-L178
Check warning on line 192 in xds/internal/xdsclient/channel.go
Codecov / codecov/patch
xds/internal/xdsclient/channel.go#L191-L192
Check warning on line 205 in xds/internal/xdsclient/channel.go
Codecov / codecov/patch
xds/internal/xdsclient/channel.go#L202-L205
Check warning on line 221 in xds/internal/xdsclient/channel.go
Codecov / codecov/patch
xds/internal/xdsclient/channel.go#L218-L221
Check warning on line 228 in xds/internal/xdsclient/channel.go
Codecov / codecov/patch
xds/internal/xdsclient/channel.go#L227-L228
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: s/errors will be returned as well/something as in paragraph 2, that mentions it is the value for the key.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Check warning on line 288 in xds/internal/xdsclient/channel.go
Codecov / codecov/patch
xds/internal/xdsclient/channel.go#L285-L288
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clarification: why status is
ServiceStatusNACKed
if only some resources have errors and some not? If i remember correctly, the server will send us all the resources by default whether we need it or not. So, we should not consider those we don't need right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the xDS transport protocol level, an ACK or a NACK is not for a particular resource, but for a version of a particular resource type.
What this means is that if we receive resources [A, B, C] of type Listener at version 1, and we like all of them, we would ACK version 1 for resource type Listener.
Later on, if we receive an update for the same resource type and we receive resource [A, B, C] at version 2, but this time we don't like resource C for some reason, we would send a NACK for version 2 for resource type Listener. But we will go ahead and use resources A and B at version 2, but we will use resource C at version 1. This information is captured in the update metadata and when a CSDS client queries us for a resource dump, we will return [A at 2], [B at 2], [C at 1, but NACKed 2]. This is taken care of at the
authority
level, which is the one that maintains the resource cache.Hope this helps.