Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testutils: add couple of log statements to the restartable listener type #7716

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Oct 9, 2024

#a71-xds-fallback
#xdsclient-refactor

Addresses #6902

RELEASE NOTES: none

@easwars easwars requested a review from zasweq October 9, 2024 18:16
@easwars easwars added this to the 1.68 Release milestone Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (b8ee37d) to head (81ab9dc).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7716      +/-   ##
==========================================
+ Coverage   81.84%   81.94%   +0.09%     
==========================================
  Files         361      361              
  Lines       27827    27829       +2     
==========================================
+ Hits        22775    22804      +29     
+ Misses       3850     3839      -11     
+ Partials     1202     1186      -16     
Files with missing lines Coverage Δ
internal/testutils/restartable_listener.go 94.11% <100.00%> (+0.36%) ⬆️

... and 21 files with indirect coverage changes

@zasweq zasweq assigned easwars and unassigned zasweq Oct 9, 2024
@easwars easwars merged commit 18a4eac into grpc:master Oct 9, 2024
14 checks passed
@easwars easwars deleted the restartable_listener_logs branch October 9, 2024 23:57
janardhanvissa pushed a commit to janardhanvissa/grpc-go that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants