-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple: switch to math/rand/v2 #7711
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7711 +/- ##
==========================================
- Coverage 81.84% 81.80% -0.04%
==========================================
Files 374 374
Lines 38151 38149 -2
==========================================
- Hits 31224 31208 -16
- Misses 5663 5672 +9
- Partials 1264 1269 +5
|
balancer/grpclb/grpclb_picker.go
Outdated
@@ -19,7 +19,7 @@ | |||
package grpclb | |||
|
|||
import ( | |||
"math/rand" | |||
"math/rand/v2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to be a little painful. But could you please rename this import as rand "math/rand/v2"
, so that we can track the package name from use sites. Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry should have been faster in reviewing this PR with such a horizontal span. I resolved the conflict.
LGTM! Thanks for taking care of this
Fixes #7293
This PR replaces usage of
math/rand
withmath/rand/v2
.RELEASE NOTES: none