Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick #7660 to v1.67.x branch #7667

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

arjan-bal
Copy link
Contributor

@arjan-bal arjan-bal commented Sep 24, 2024

Addresses: #7641
Original PR: #7660

RELEASE NOTES:

  • transport: Fix a bug causing stream failures due to miscalculation of the flow control window in both clients and servers.

@arjan-bal arjan-bal added Type: Bug Area: Transport Includes HTTP/2 client/server and HTTP server handler transports and advanced transport features. labels Sep 24, 2024
@arjan-bal arjan-bal added this to the 1.67 Release milestone Sep 24, 2024
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.95%. Comparing base (02bbb65) to head (7398679).
Report is 1 commits behind head on v1.67.x.

Additional details and impacted files
@@             Coverage Diff             @@
##           v1.67.x    #7667      +/-   ##
===========================================
+ Coverage    81.93%   81.95%   +0.01%     
===========================================
  Files          361      361              
  Lines        27813    27813              
===========================================
+ Hits         22788    22793       +5     
+ Misses        3838     3833       -5     
  Partials      1187     1187              
Files with missing lines Coverage Δ
internal/transport/transport.go 92.69% <100.00%> (+1.53%) ⬆️

... and 18 files with indirect coverage changes

@arjan-bal arjan-bal assigned arjan-bal and unassigned easwars Sep 24, 2024
@arjan-bal arjan-bal merged commit 935f8cb into grpc:v1.67.x Sep 24, 2024
14 checks passed
@arjan-bal arjan-bal deleted the cherrypick-flow-control-fix branch September 24, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Transport Includes HTTP/2 client/server and HTTP server handler transports and advanced transport features. Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants