Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.*: fix comments #7504

Merged
merged 1 commit into from
Aug 13, 2024
Merged

.*: fix comments #7504

merged 1 commit into from
Aug 13, 2024

Conversation

murongshaozong
Copy link
Contributor

@murongshaozong murongshaozong commented Aug 13, 2024 •
edited by arvindbr8
Loading

RELEASE NOTES: none

@murongshaozong
chore: fix some comments
302bcfc 
Signed-off-by: murongshaozong <[email protected]>
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 13, 2024 •
edited
Loading

CLA Signed

  • ✅login: murongshaozong / (302bcfc)

The committers listed above are authorized under a signed CLA.

@aranjans aranjans self-requested a review August 13, 2024 09:11
@aranjans aranjans self-assigned this Aug 13, 2024
purnesh42H
purnesh42H approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@purnesh42H purnesh42H assigned dfawley and unassigned aranjans Aug 13, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.63%. Comparing base (ced812e) to head (302bcfc).
Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7504      +/-   ##
==========================================
+ Coverage   81.58%   81.63%   +0.04%     
==========================================
  Files         358      358              
  Lines       27388    27388              
==========================================
+ Hits        22345    22358      +13     
+ Misses       3828     3819       -9     
+ Partials     1215     1211       -4
Files Coverage Δ
server.go 82.55% <ø> (-0.30%) ⬇️
stream.go 81.49% <ø> (ø)

... and 19 files with indirect coverage changes

@arvindbr8 arvindbr8 added the Type: Documentation Documentation or examples label Aug 13, 2024
@arvindbr8 arvindbr8 added this to the 1.66 Release milestone Aug 13, 2024
@arvindbr8 arvindbr8 changed the title chore: fix some comments .*: fix comments Aug 13, 2024
@arvindbr8 arvindbr8 merged commit 3cb3342 into grpc:master Aug 13, 2024
13 checks passed
infovivek2020 pushed a commit to infovivek2020/grpc-go that referenced this pull request Aug 18, 2024
@murongshaozong @infovivek2020
.*: fix comments (grpc#7504)
0716f4a
@tbg tbg mentioned this pull request Nov 27, 2024
Draft
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aranjans aranjans aranjans approved these changes

@arvindbr8 arvindbr8 arvindbr8 approved these changes

@purnesh42H purnesh42H purnesh42H approved these changes

Assignees

@dfawley dfawley

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.66 Release
Development

Successfully merging this pull request may close these issues.
5 participants
@murongshaozong @purnesh42H @arvindbr8 @aranjans @dfawley