advancedtls: Add notes about required vs. optional for FileWatcherOptions #7165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erm-g
reviewed
Apr 25, 2024
security/advancedtls/crl_provider.go
Outdated
| RefreshDuration time.Duration // Time interval (default value is 1 hour) between CRLDirectory scans, can't be smaller than 1 minute | ||
| CRLReloadingFailedCallback func(err error) // Custom callback executed when a CRL file can’t be processed | ||
| CRLDirectory string // Required: Path of the directory containing CRL files | ||
| RefreshDuration time.Duration // Optional, default 1 hour: Time interval between CRLDirectory scans, can't be smaller than 1 minute |
There was a problem hiding this comment.
Would you prefer
// Optional: Time interval (default is 1 hour) between...
There was a problem hiding this comment.
Changed, I like that more
erm-g
approved these changes
Apr 25, 2024
arvindbr8
approved these changes
Apr 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear up required vs. optional fields in FileWatcherOptions
RELEASE NOTES: none