-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS resolving with timeout #6917
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6917 +/- ##
==========================================
- Coverage 83.70% 82.38% -1.32%
==========================================
Files 288 296 +8
Lines 30921 31468 +547
==========================================
+ Hits 25883 25926 +43
- Misses 3976 4475 +499
- Partials 1062 1067 +5
|
5b77a44
to
d2ec263
Compare
Hi @and1truong, Such a wide-sweeping change would require cross-language agreement for adding this. Instead, maybe you can add a global in the |
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
Thanks for comment. I will start working on this next week. |
d2ec263
to
8862fe5
Compare
This PR is labeled as requiring an update from the reporter, and no update has been received after 6 days. If no update is provided in the next 7 days, this issue will be automatically closed. |
82a0ea9
to
c9ea67f
Compare
c9ea67f
to
d9dcc72
Compare
@and1truong -- let us know if this is ready for another review |
@arvindbr8 I pushed the changes recommended by @dfawley. |
okay, I'll request @dfawley to take another look at this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for the last few small things. Thank you for the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, mostly formatting.
Thanks for the PR @and1truong. We look forward to seeing your next PR. |
Currently, the DNS resolver does not have a timeout mechanism for DNS resolution. In some edge cases, where the DNS server is slow to respond, this can lead to stale records being used, resulting in failed connections or other issues.
This pull request adds a configurable timeout for DNS resolution, which can be set by the user to a value that suits their needs. The default value is set to 5 seconds, which should be sufficient for most cases. If the DNS server does not respond within the specified time, the resolver will cancel the request and move on to the next available server.
Please review and let me know if you have any questions or concerns.
Thanks!
RELEASE NOTES: