Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientconn: add channel ID to some idleness logs #6459

Merged
merged 1 commit into from
Jul 21, 2023
Merged

clientconn: add channel ID to some idleness logs #6459

merged 1 commit into from
Jul 21, 2023

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Jul 19, 2023 •
edited
Loading

While debugging an issue, I saw the following log:

2023/07/19 01:01:23 INFO: [core] ClientConn asked to exit idle mode when not in idle mode

And in this application, there are multiple gRPC channels and without the channel ID, this log is not very useful. I also added the current state to the log line.

RELEASE NOTES: none

@easwars easwars requested a review from dfawley July 19, 2023 19:48
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Jul 19, 2023
@easwars easwars added this to the 1.58 Release milestone Jul 19, 2023
@dfawley dfawley assigned easwars and unassigned dfawley Jul 20, 2023
@easwars easwars merged commit f1fc2ca into grpc:master Jul 21, 2023
1 check passed
@easwars easwars deleted the clientconn_improve_logs branch July 21, 2023 00:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@easwars easwars

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.58 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@easwars @dfawley