balancer/weightedtarget: pause picker updates during UpdateClientConnState #5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
reviewed
Jul 21, 2022
Comment on lines
1222
to
1250
| type updateStateBalancerBuilder struct{} | ||
|
|
||
| func (updateStateBalancerBuilder) Build(cc balancer.ClientConn, opts balancer.BuildOptions) balancer.Balancer { | ||
| return &updateStateBalancer{cc: cc} | ||
| } | ||
|
|
||
| const updateStateBalancerName = "update_state_balancer" | ||
|
|
||
| func (updateStateBalancerBuilder) Name() string { | ||
| return updateStateBalancerName | ||
| } | ||
|
|
||
| func init() { | ||
| balancer.Register(updateStateBalancerBuilder{}) | ||
| } | ||
|
|
||
| type updateStateBalancer struct { | ||
| cc balancer.ClientConn | ||
| balancer.Balancer | ||
| } | ||
|
|
||
| func (b *updateStateBalancer) UpdateClientConnState(s balancer.ClientConnState) error { | ||
| b.cc.UpdateState(balancer.State{ConnectivityState: connectivity.TransientFailure, Picker: nil}) | ||
| b.cc.UpdateState(balancer.State{ConnectivityState: connectivity.Ready, Picker: nil}) | ||
| return nil | ||
| } | ||
|
|
||
| func (b *updateStateBalancer) Close() {} | ||
|
|
There was a problem hiding this comment.
Can we replace this with a stub balancer?
There was a problem hiding this comment.
Oh yes, good call. Done.
easwars
approved these changes
Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5211
Even though the picker is updated synchronously in
UpdateClientConnState, multiple updates could result inUpdateStatecalls to the parent if this is not done to suppress them.RELEASE NOTES: n/a