credentials/google: stub out the oauth package in test #5118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The oauth package, as part of checking whether it is running on GCE, creates a persistent connection to the metadata server. This persistent connection spawns a couple of goroutines, one to read and one to write. And these goroutines show up in our leakchecker. We are not testing perRPC credentials in this test and can safely stub out the oauth package to make the leakchecker happy.
dfawley
reviewed
Jan 11, 2022
credentials/google/google_test.go
Outdated
| } | ||
| origNewADC := newADC | ||
| newADC = func(context.Context) (credentials.PerRPCCredentials, error) { | ||
| return &testPerRPCCreds{}, nil |
Member
There was a problem hiding this comment.
Since testPerRPCCreds.PerRPCCredentials is not initialized, then it must not be getting called, right? Can't this just return nil, nil then, and delete that type?
dfawley
approved these changes
Jan 11, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5091
The
oauthpackage, as part of checking whether it is running on GCE,creates a persistent connection to the metadata server. This persistent
connection spawns a couple of goroutines, one to read and one to write.
And these goroutines show up in our leakchecker.
We are not testing perRPC credentials in this test and can safely stub
out the
oauthpackage to make the leakchecker happy.RELEASE NOTES: none