Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: Improve error message when an unknown method is invoked. #2723

Merged
merged 1 commit into from
Mar 27, 2019
Merged

server: Improve error message when an unknown method is invoked. #2723

merged 1 commit into from
Mar 27, 2019

Conversation

dsymonds
Copy link
Contributor

Previously only unknown service <x> was returned, which is misleading
when the service is known but the method is unknown.

dfawley
dfawley requested changes Mar 27, 2019
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. One suggestion to also fix the tracing.

server.go Outdated Show resolved Hide resolved
@dsymonds
server: Improve error message when an unknown method is invoked.
85226ed 
Previously only `unknown service <x>` was returned, which is misleading
when the service is known but the method is unknown.
dfawley
dfawley approved these changes Mar 27, 2019
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again!

@dfawley dfawley merged commit f1437f7 into grpc:master Mar 27, 2019
@dfawley dfawley added the Type: Feature New features or improvements in behavior label Mar 28, 2019
@dfawley dfawley added this to the 1.20 Release milestone Mar 28, 2019
@dsymonds dsymonds deleted the error-message branch July 2, 2019 23:21
@lock lock bot locked as resolved and limited conversation to collaborators Dec 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees
No one assigned
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.20 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dsymonds @dfawley