Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stats: add WireLength to stats.InPayload #2711

Merged
merged 1 commit into from
Mar 25, 2019
Merged

stats: add WireLength to stats.InPayload #2711

merged 1 commit into from
Mar 25, 2019

Conversation

ilylia
Copy link
Contributor

@ilylia ilylia commented Mar 22, 2019 •
edited by menghanl
Loading

fixes #2692

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@ilylia
Copy link
Contributor Author

ilylia commented Mar 22, 2019

github user fixed.

@menghanl menghanl changed the title add WireLength to stats.InPayload (#2692) add WireLength to stats.InPayload Mar 22, 2019
@menghanl menghanl changed the title add WireLength to stats.InPayload stats: add WireLength to stats.InPayload Mar 22, 2019
@menghanl
Copy link
Contributor

Thanks for the fix!

Can you sign the CLA? If you already did, can you try to post "I signed it"?

@ilylia
Copy link
Contributor Author

ilylia commented Mar 23, 2019

I signed it.

@menghanl menghanl closed this Mar 23, 2019
@menghanl menghanl reopened this Mar 23, 2019
@ilylia
Copy link
Contributor Author

ilylia commented Mar 24, 2019 •
edited
Loading

I signed it.

@menghanl
I have already signed the CLA with ID and email the same as the commit, what else do I need to do?

Sorry! I missed the signature step.
Please recheck again.

@menghanl
Copy link
Contributor

Thanks for the change!

@menghanl menghanl merged commit ed10349 into grpc:master Mar 25, 2019
@dfawley dfawley added this to the 1.20 Release milestone Mar 28, 2019
ajwerner added a commit to ajwerner/grpc-go that referenced this pull request Jul 24, 2019
@ajwerner
server: populate WireLength on stats.InPayload for unary RPCs
de0849b 
Fixes grpc#2692 which was incompletely fixed by grpc#2711.

Also adds a basic unit test which provides scaffolding for further testing of
the stats logic.
@ajwerner ajwerner mentioned this pull request Jul 24, 2019
Merged
ajwerner added a commit to ajwerner/grpc-go that referenced this pull request Jul 24, 2019
@ajwerner
server: populate WireLength on stats.InPayload for unary RPCs
1a729ca 
Fixes grpc#2692 which was incompletely fixed by grpc#2711.

Also adds a basic unit test which provides scaffolding for further testing of
the stats logic.
ajwerner added a commit to ajwerner/grpc-go that referenced this pull request Jul 24, 2019
@ajwerner
server: populate WireLength on stats.InPayload for unary RPCs
3e986df 
Fixes grpc#2692 which was incompletely fixed by grpc#2711.

Also adds updates stats/stat_test.go to sanity check WireLength.
menghanl pushed a commit that referenced this pull request Jul 24, 2019
@ajwerner @menghanl
server: populate WireLength on stats.InPayload for unary RPCs (#2932)
b5748ca 
Fixes #2692 which was incompletely fixed by #2711.

Also adds updates stats/stat_test.go to sanity check WireLength.
ajwerner added a commit to ajwerner/grpc-go that referenced this pull request Jul 25, 2019
@ajwerner
server: populate WireLength on stats.InPayload for unary RPCs (grpc#2932
359d7c2 
)

Fixes grpc#2692 which was incompletely fixed by grpc#2711.

Also adds updates stats/stat_test.go to sanity check WireLength.
menghanl pushed a commit that referenced this pull request Jul 25, 2019
@ajwerner @menghanl
server: populate WireLength on stats.InPayload for unary RPCs (#2932)
d95b9a7 
Fixes #2692 which was incompletely fixed by #2711.

Also adds updates stats/stat_test.go to sanity check WireLength.
menghanl pushed a commit that referenced this pull request Jul 25, 2019
@ajwerner @menghanl
server: populate WireLength on stats.InPayload for unary RPCs (#2932)
f0893a5 
Fixes #2692 which was incompletely fixed by #2711.

Also adds updates stats/stat_test.go to sanity check WireLength.
@lock lock bot locked as resolved and limited conversation to collaborators Sep 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
1.20 Release
Development

Successfully merging this pull request may close these issues.

WireLength is not set on the stats.InPayload used as input to stats.Handler.HandleRPC()
4 participants
@ilylia @thelinuxfoundation @menghanl @dfawley