balancer: make sure non-nil done returned by Pick is called #2688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Special case: when SubConn returned by Picker is not Ready, call done before looping back to re-pick.
dfawley
approved these changes
Mar 13, 2019
picker_wrapper.go
Outdated
| @@ -165,6 +165,14 @@ func (bp *pickerWrapper) pick(ctx context.Context, failfast bool, opts balancer. | |||
| } | |||
| return t, done, nil | |||
| } | |||
| if done != nil { | |||
| done(balancer.DoneInfo{ | |||
| Err: nil, | |||
There was a problem hiding this comment.
These are all the defaults - maybe delete and a comment "default DoneInfo indicates RPC did not occur"?
There was a problem hiding this comment.
If the field was named NoBytesSent, we would want to set it to true (It's great that's not the case :) )
Deleted and explain in a comment.
There was a problem hiding this comment.
Didn't test this because returning a non-Ready SubConn from picker is very racy.
test/balancer_test.go
Outdated
| // Stop server and at the same time send RPCs. There are chances that picker | ||
| // is not updated in time, causing a non-Ready SubConn to be returned. | ||
| var wg sync.WaitGroup | ||
| wg.Add(1) |
There was a problem hiding this comment.
The loneliest waitgroup. Maybe use a channel instead?
dfawley
approved these changes
Mar 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Special case: when SubConn returned by Picker is not Ready, call done before
looping back to re-pick.