Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: add keepalive example #2637

Merged
merged 3 commits into from
Feb 15, 2019
Merged

examples: add keepalive example #2637

merged 3 commits into from
Feb 15, 2019

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Feb 12, 2019

Fixes #2482

@dfawley dfawley added the Type: Documentation Documentation or examples label Feb 12, 2019
@dfawley dfawley added this to the 1.19 Release milestone Feb 12, 2019


```
go run server/main.go
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GODEBUG=http2debug=2 for server too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considered and decided against since the client shows all the frames already. No reason to show it twice.

@dfawley dfawley merged commit 29c406a into grpc:master Feb 15, 2019
@dfawley dfawley deleted the keepalive branch February 15, 2019 00:58
@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

examples: keepalive
2 participants