grpclb: drop only when at least one SubConn is ready #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
force-pushed
the
grpclb_drop_only_if_ready
branch
from
7cb2c9b to
c58281c
Compare
menghanl
force-pushed
the
grpclb_drop_only_if_ready
branch
from
c58281c to
0eaaa5e
Compare
lyuxuan
reviewed
Feb 27, 2019
balancer/grpclb/grpclb_test.go
Outdated
| @@ -898,24 +896,34 @@ func TestGRPCLBStatsStreamingDrop(t *testing.T) { | |||
| c := 0 | |||
lyuxuan
approved these changes
Feb 27, 2019
and delete c
menghanl
force-pushed
the
grpclb_drop_only_if_ready
branch
from
87f12c8 to
eca4680
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2622