Fix error message formatting #2615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
suggested changes
Feb 5, 2019
test/channelz_test.go
Outdated
| @@ -355,7 +355,7 @@ func (s) TestCZServerSocketRegistrationAndDeletion(t *testing.T) { | |||
|
|
|||
| ns, end := channelz.GetServerSockets(ss[0].ID, startID, c.max) | |||
| if int64(len(ns)) != c.length || end != c.end { | |||
| return false, fmt.Errorf("GetServerSockets(%d) = %+v (len of which: %d), end: %+v, want len(GetServerSockets(%d)) = %d, end: %+v", c.start, ns, len(ns), end, c.start, c.length, c.end) | |||
| return false, fmt.Errorf("getServerSockets(%d) = %+v (len of which: %d), end: %+v, want len(GetServerSockets(%d)) = %d, end: %+v", c.start, ns, len(ns), end, c.start, c.length, c.end) | |||
There was a problem hiding this comment.
Revert this. GetServerSockets is the function name.
test/channelz_test.go
Outdated
| @@ -1320,14 +1320,14 @@ func (s) TestCZSocketGetSecurityValueTLS(t *testing.T) { | |||
| return false, fmt.Errorf("the SocketData.Security is of type: %T, want: *credentials.TLSChannelzSecurityValue", skt.SocketData.Security) | |||
| } | |||
| if !reflect.DeepEqual(securityVal.RemoteCertificate, cert.Certificate[0]) { | |||
| return false, fmt.Errorf("SocketData.Security.RemoteCertificate got: %v, want: %v", securityVal.RemoteCertificate, cert.Certificate[0]) | |||
| return false, fmt.Errorf("socketData.Security.RemoteCertificate got: %v, want: %v", securityVal.RemoteCertificate, cert.Certificate[0]) | |||
There was a problem hiding this comment.
Revert. SocketData is the field name.
test/healthcheck_test.go
Outdated
| @@ -312,7 +312,7 @@ func (s) TestHealthCheckWithGoAway(t *testing.T) { | |||
| // make some rpcs to make sure connection is working. | |||
| if err := verifyResultWithDelay(func() (bool, error) { | |||
| if _, err := tc.EmptyCall(context.Background(), &testpb.Empty{}); err != nil { | |||
| return false, fmt.Errorf("TestService/EmptyCall(_, _) = _, %v, want _, <nil>", err) | |||
| return false, fmt.Errorf("testService/EmptyCall(_, _) = _, %v, want _, <nil>", err) | |||
There was a problem hiding this comment.
Revert this file. TestService is the service name.
test/rawConnWrapper.go
Outdated
| @@ -222,7 +222,7 @@ func (rcw *rawConnWrapper) wantAnyFrame() (http2.Frame, error) { | |||
| func (rcw *rawConnWrapper) encodeHeaderField(k, v string) error { | |||
| err := rcw.hpackEnc.WriteField(hpack.HeaderField{Name: k, Value: v}) | |||
| if err != nil { | |||
| return fmt.Errorf("HPACK encoding error for %q/%q: %v", k, v, err) | |||
| return fmt.Errorf("hPACK encoding error for %q/%q: %v", k, v, err) | |||
Signed-off-by: CodeLingo Bot <[email protected]>
Signed-off-by: CodeLingo Bot <[email protected]>
|
Hi @menghanl , Shane from CodeLingo here. We stuffed up, sorry. We made an error when writing a Tenet that was used on your repository that resulted in incorrect changes to your code in some edge cases. We've fixed the bug and improved our internal process to prevent this happening again. We're keen to learn how we can best help dev teams without getting in your way. Your feedback would really help us, my email's [email protected]. Thanks, |
menghanl
approved these changes
Feb 7, 2019
Closed
menghanl
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CodeLingo to automatically fix function comments following the
Code Review Comments guidelines.
This patch was generated by running the CodeLingo Rewrite Flow over the "go-error-fmt" Tenet. Note: the same Tenet can be used to automate PR reviews and generate contributor docs.
Install CodeLingo to drive Continuous Higher Standards
Learn about CodeLingo