Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: errors #2534

Merged
merged 8 commits into from
Dec 22, 2018
Merged

example: errors #2534

merged 8 commits into from
Dec 22, 2018

Conversation

canguler
Copy link

No description provided.

@canguler canguler requested a review from menghanl December 21, 2018 21:43
dfawley
dfawley reviewed Dec 21, 2018
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make this conform to the rest of the feature examples? I don't think it needs to be rewritten against the echo server (it wouldn't hurt if it's easy enough), but please make the client and server use address/port flags when running. Thanks!

@canguler canguler merged commit 25de51f into grpc:master Dec 22, 2018
@menghanl menghanl added this to the 1.18 Release milestone Dec 27, 2018
@menghanl menghanl added the Type: Documentation Documentation or examples label Dec 27, 2018
@lyuxuan lyuxuan mentioned this pull request Dec 27, 2018
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley left review comments

@menghanl menghanl menghanl approved these changes

Assignees

@menghanl menghanl

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.18 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@canguler @menghanl @dfawley